| 03:50 | <Domenic> | MikeSmith: "Unicode serialization of an origin" was removed |
| 03:51 | <Domenic> | As was the worker's documents, I believe |
| 03:51 | <Domenic> | I thought we fixed the latter at least in service worker |
| 05:08 | <MikeSmith> | Domenic: seems like they much still be in there somewhere |
| 05:08 | MikeSmith | looks |
| 05:09 | <MikeSmith> | oh I guess by “removed” you mean, removed from HTML |
| 05:10 | <MikeSmith> | but the references still must be in the Service Workers spec |
| 05:10 | <Domenic> | ya |
| 05:10 | <MikeSmith> | OK |
| 05:10 | <MikeSmith> | I’ll look and try to write up a patch fixing that |
| 05:24 | <MikeSmith> | Domenic: so yeah about “the worker's documents” I see again now the patch I wrote for changing that |
| 05:24 | <MikeSmith> | https://github.com/w3c/ServiceWorker/pull/1124 |
| 05:24 | <MikeSmith> | which has just been waiting for me to make a change that jungkee requested |
| 05:25 | <MikeSmith> | so will do that |
| 05:25 | <MikeSmith> | then I’ll do that "Unicode serialization of an origin" one |
| 05:41 | <MikeSmith> | Domenic: OK https://github.com/w3c/ServiceWorker/pull/1124 righted |
| 05:54 | <MikeSmith> | Domenic: OK raised https://github.com/w3c/ServiceWorker/pull/1160 just now |
| 06:08 | <annevk> | MikeSmith: FWIW, pretty sure there are open issues on both |
| 06:08 | <annevk> | MikeSmith: that I filed |
| 07:31 | <MikeSmith> | annevk: Ah ok I'll update the commit messages to reference the issues |
| 09:07 | <zcorpan> | MikeSmith: https://github.com/w3c/web-platform-tests/pull/6167#issuecomment-307442381 also shouldn't have been merged while it has the status:needs-spec-decision label |
| 09:19 | <MikeSmith> | zcorpan: oops |
| 13:57 | <Domenic> | the spec PR was merged, I wonder what spec decision zcorpan thought was needed |
| 14:28 | <MikeSmith> | OK well I’ll follow up with jgraham about the other thing |
| 23:26 | <GPHemsley> | hmm... jsdom/whatwg-url has a funky bug |
| 23:26 | <GPHemsley> | https://quuz.org/url/liveview.html#http://0x100000000/test |
| 23:26 | <GPHemsley> | I'm not really sure what it's doing here |
| 23:28 | <MikeSmith> | GPHemsley: indeed weird |
| 23:28 | <MikeSmith> | wonder how it ever gets there |
| 23:28 | <GPHemsley> | yeah, I don't understand why the 16 sticks around |
| 23:28 | <MikeSmith> | I mean given there’s no hash in the URL |
| 23:29 | <GPHemsley> | https://quuz.org/url/liveview.html#http://0x123456789/test |
| 23:29 | <MikeSmith> | oh I was just thinking of the hash |
| 23:29 | <GPHemsley> | oh, I'm looking at IPv4/domain parsing |
| 23:29 | <MikeSmith> | d’oh |
| 23:29 | <GPHemsley> | Anything over 0xFFFFFFFF should be IPv4 serialized as 0.0.0.0 |
| 23:29 | <MikeSmith> | ignore everything I said :) I just noticed the actual URL being tested |
| 23:30 | <GPHemsley> | now, what other functions do with that is another story |
| 23:31 | <GPHemsley> | the spec defines an IPv4 address as 32-bit, but doesn't really enforce it anywhere |
| 23:31 | <GPHemsley> | not explicitly, anyway |
| 23:31 | <GPHemsley> | IPv4 serialize doesn't even explicitly require operating on an IPv4 address |
| 23:31 | <GPHemsley> | oh wait, yes it does |
| 23:32 | <GPHemsley> | but it doesn't check that that is the case |
| 23:32 | <GPHemsley> | it just silently discards anything above 32 bits |
| 23:32 | <GPHemsley> | but from looking at the jsdom/whatwg-url code, the problem is not in the IPv4 serialize function |
| 23:32 | <GPHemsley> | as that appears to be spec-compliant |
| 23:33 | <GPHemsley> | so somewhere down the line, that 16 sticks around |
| 23:33 | <GPHemsley> | compare: https://quuz.org/url/liveview.html#http://0x10000000/test |
| 23:33 | <GPHemsley> | which is indeed 16.0.0.0 |
| 23:44 | <GPHemsley> | it seems jsdom/whatwg-url doesn't have unit tests :/ |
| 23:57 | <Sebmaster> | GPHemsley: it imports web platform tests |
| 23:59 | <GPHemsley> | yeah, but that only tests the endpoints |