| 00:25 | <railgun> | annevk: is this correct for #3474? https://railgun.s-ul.eu/iAoiJLz6 |
| 01:26 | <Domenic> | MikeSmith: any luck? |
| 01:26 | <MikeSmith> | Domenic: yeah |
| 01:27 | <MikeSmith> | still wo |
| 01:27 | <MikeSmith> | *still working ont it |
| 01:27 | <Domenic> | <3 |
| 01:28 | <MikeSmith> | so far, “fixed” the fact that Rhino’s parser doesn’t allow “const” in “for (const foo of bar)” |
| 01:28 | <MikeSmith> | only allows var and let there |
| 01:29 | <MikeSmith> | it also doesn’t understand the `async` keyword for function |
| 01:29 | <MikeSmith> | so, made it handle that |
| 01:29 | <MikeSmith> | and now working on `await` |
| 05:37 | <MikeSmith> | Domenic: oK, build un-broke |
| 05:39 | <MikeSmith> | hmm, green at https://travis-ci.org/whatwg/streams/builds/344010078 at least |
| 05:42 | <MikeSmith> | OK also at https://travis-ci.org/whatwg/streams/builds/344010699 now |
| 05:42 | <MikeSmith> | and https://github.com/whatwg/streams/pull/884 green too |
| 09:57 | <JakeA> | annevk: to clarify, are you happy with me doing a PR for that pixelated thing? |
| 10:00 | <annevk> | JakeA: I guess; are you by any chance happy to rebase my PR after landing it? |
| 10:01 | <JakeA> | annevk: let's just wait until your stuff lands |
| 10:03 | <annevk> | JakeA: I'm letting it sit a bit since I'm trying to sort out some web components stuff |
| 10:04 | <annevk> | JakeA: since there's an upcoming meeting I prioritized that a bit |
| 10:04 | <annevk> | JakeA: but yeah, that seemed easier to me too |
| 10:06 | <JakeA> | annevk: yeah, it isn't urgent |
| 14:45 | <nox> | annevk: I've thought about your ping from yesterday, |
| 14:46 | <nox> | annevk: and I think there is precedent for that change in DOM or HTML, let me try to find that. |
| 14:46 | <nox> | annevk: Btw, r? https://github.com/whatwg/dom/pull/402 |
| 14:47 | <nox> | annevk: Your issue about insertion steps reminded me of https://github.com/whatwg/dom/pull/71, but that's slightly unrelated I guess. |
| 14:51 | <annevk> | nox: I think that has r+ but needs tests to land |
| 14:51 | <annevk> | nox: and it seems it needs to be rebased at this point too unfortunately |
| 14:52 | <nox> | annevk: Ok. |
| 14:52 | <annevk> | nox: seems a little similar to 71, yes |
| 14:52 | <nox> | annevk: Why 'topic: shadow'? |
| 14:52 | <annevk> | nox: though no script execution there |
| 14:53 | <annevk> | nox: retargeting is shadow tree stuff |
| 14:53 | <nox> | Oh, TIL. |
| 15:13 | <smaug____> | annevk: in diff view for a spec change, what does yellow color mean? |
| 15:15 | <smaug____> | hmm, perhaps the tool just somewhat randomly marks something as removed, something as new addition, and something as changed |
| 15:16 | <annevk> | smaug____: it might not be perfect |
| 15:17 | <annevk> | smaug____: Preview has the change integrated |
| 15:17 | <annevk> | I thought we had some thread that ended up rejecting read-write classes inheriting from read-only classes? In particular DOMRect and DOMRectReadOnly, but that pattern only seems to have spread? |
| 15:18 | <annevk> | I guess the idea is that the base class is actually mutable despite saying ReadOnly, it just doesn't expose public accessors for it? Seems a bit weird |
| 16:10 | <lgrahl> | Hey :) |
| 16:10 | <lgrahl> | Domenic: Was there something else I should take a look at and forgot to do so? |
| 16:22 | <wanderview> | annevk: if an img element hits a redirect, should the img.src property reflect the final URL? |
| 17:05 | <annevk> | wanderview: no |
| 17:05 | <wanderview> | ok |
| 17:05 | <wanderview> | annevk: that explains why I didn't see the fragment disappear from the .src property when we were stripping it |
| 17:06 | <Domenic> | lgrahl: all good! |
| 20:04 | <TabAtkins> | annevk: thank you for the review! |
| 21:24 | <annevk> | TabAtkins: ooh cool, looking forward to reviewing the fixes tomorrow; thanks |