| 13:06 | <annevk> | No existing tests for "pixelated"; quelle surprise |
| 13:14 | <shannu> | I am working on the following issue https://github.com/w3c/web-platform-tests/issues/8616 and I found that i have to add amaplike declaration at the line highlighted in the document https://github.com/w3c/web-platform-tests/blob/master/resources/idlharness.js#L2197 .So I thought I should add a code like this https://pastebin.mozilla.org/9078942 I s it right? |
| 13:14 | <shannu> | And is it necessary to be readonly? |
| 13:14 | <shannu> | if it is what should be the key values I should use? |
| 13:14 | <shannu> | It would be great if some one helps me. |
| 13:14 | <shannu> | thank you |
| 13:28 | <ricea> | shannu: I think it will need a lot more code than that. You can look at https://www.npmjs.com/package/webidl2#iterable--legacyiterable--maplike--setlike-declarations to see how the parser represents setlike and maplike types, and then work out how to test those interfaces. |
| 13:29 | <shannu> | ricea: Thank you |
| 13:32 | <ricea> | shannu: It might be easier to start by looking for interfaces that are implicitly iterable as described in that issue, and then call this.add_iterable_members on them. |
| 13:34 | <shannu> | Ok |
| 14:16 | <nox> | https://drafts.csswg.org/css-lists/#counter-functions |
| 14:16 | <nox> | Isn't it a bit weird for the first argument of counter() to be <ident>? Does it make sense to be able to name a counter 'inherit'? |
| 14:18 | <nox> | AFAIK counter-increment and friends want a <custom-ident>, |
| 14:19 | <nox> | so you can't actually use a counter named 'inherit' in them. |
| 14:31 | <annevk> | JakeA: so http://software.hixie.ch/utilities/js/live-dom-viewer/saved/5807 Chrome doesn't seem to resize the SVG |
| 14:31 | <annevk> | JakeA: Safari does resize it, but cannot draw it (or ends up drawing nothing) |
| 14:32 | <annevk> | JakeA: unclear where it fails in Firefox |
| 14:35 | <JakeA> | annevk: ugh, yeah. It should absolutely be 100x100 afterwards. I guess this stuff is relatively new. |
| 14:36 | <annevk> | JakeA: if I remove 1,1,1,1 btw nobody still draws anything |
| 14:37 | <JakeA> | annevk: does it work if you give the svg an explicit width & height? |
| 14:37 | <annevk> | JakeA: no, but that has made me think whether that's required here |
| 14:38 | <annevk> | JakeA: can you crop when there's no intrinsic dimensions, I guess you should be able to since for SVG we resize first and then crop, but we only specced that in the PR |
| 14:38 | <JakeA> | annevk: I thought <img> took an intrinsic height from the viewbox |
| 14:39 | <annevk> | JakeA: this differs between Chrome and Safari too, that's why I added an explicit width/height |
| 14:39 | <annevk> | JakeA: I think Safari might actually do that correctly, where it takes up the maximum width possible |
| 14:39 | <annevk> | JakeA: per replaced element sizing in CSS 2.1 |
| 14:40 | <annevk> | I can't believe even that is still non-interoperable in 2018 |
| 14:40 | <JakeA> | SVG has no love from browsers |
| 14:41 | <JakeA> | It's probably the biggest divide between developer interest and browser interest |
| 14:41 | <annevk> | Tell foolip |
| 14:42 | <annevk> | I'm hoping we can improve SVG a bit by leaning on the things that are common between CSS, <canvas>, and SVG, and give them common underpinnings |
| 14:42 | <annevk> | But that's only part of the issue I suppose |
| 14:43 | <annevk> | You know, sometimes I don't mind that moratorium idea so much |
| 14:43 | <annevk> | There's a lot of technical debt |
| 14:43 | <annevk> | A lot |
| 14:43 | <JakeA> | :D |
| 14:44 | <JakeA> | Yeah, I'd like SVG to stop being a special thing. Like, maybe allow <path> etc outside svg |
| 14:44 | <annevk> | <canvas> has <path>'s d="" attribute |
| 14:44 | <JakeA> | And make <svg> some kind of separate viewboxing thing. |
| 14:45 | <Ms2ger> | But *what working group* would spec that? |
| 14:45 | <JakeA> | heh |
| 14:45 | <annevk> | (Minor nit: emphasis solely goes on what, iirc.) |
| 15:02 | <nox> | https://github.com/w3c/csswg-drafts/pull/2377 |
| 15:03 | <nox> | JakeA: We would love you if you implemented SVG in Servo. :P |
| 15:04 | <JakeA> | I'm the ideas guy not the science guy :D |
| 15:04 | <nox> | Ah ah. |
| 15:05 | <JakeA> | nox: Is the feeling that SVG is just too complicated? Because I don't think developers would be against something else a little more GPU-aligned. |
| 15:05 | <nox> | JakeA: Nah, the feeling is that days are still only 24 hours long even for Servo devs. :) |
| 15:07 | <JakeA> | nox: super excited about servo. Great seeing bits of it going into Firefox too. |
| 15:07 | <nox> | Thanks! |
| 15:12 | <Ms2ger> | annevk, http://ln.hixie.ch/?start=1086387609&count=1 appears to back me :) |
| 15:21 | <jgraham> | Ah I see I came to the right place for an argument about Hixie's use of typography 14 years ago |
| 15:23 | <astearns> | nox: could you open an issue/PR on counter()/<ident>? |
| 15:25 | <nox> | astearns: I don't understand what that means. |
| 15:25 | <nox> | I did a PR. |
| 15:25 | <astearns> | oh sorry, I didn't check |
| 15:25 | <nox> | I linked to it earlier. https://github.com/w3c/csswg-drafts/pull/2377 |
| 15:25 | <nox> | astearns: No problem. :) |
| 15:26 | <astearns> | thanks for the PR - now I'll go bug TabAtkins :) |
| 15:27 | <nox> | astearns: Cool. Forgot to mention that the test linked in that PR already passes in Safari and Chrome, |
| 15:27 | <astearns> | even better |
| 15:27 | <nox> | astearns: and I suspect it was passing too in pre-Stylo Firefox, but I'm too lazy to actually confirm that. |
| 15:27 | <nox> | ecobos may know how to check that easily. |
| 15:28 | <TabAtkins> | nox: danke |
| 15:28 | <ecobos> | nox: layout.css.servo.enabled=false should still work, though not for long |
| 15:28 | <nox> | ecobos: Oh right, somehow I almost went and read nsCSSParser.cpp, |
| 15:29 | <nox> | thanks for saving me. |
| 15:29 | <nox> | ecobos: Do I need to restart Firefox? |
| 15:29 | <ecobos> | nox: nah, just reload |
| 15:29 | <nox> | ecobos: It was already broken, then. |
| 15:30 | <ecobos> | TabAtkins: while you're around, what about https://github.com/w3c/csswg-drafts/pull/2168? It's trivial and has been sitting around for months. Blink & Firefox don't implement the special behavior of display: contents for `<applet>` because well, it's no longer a special element in any way. |
| 15:30 | <nox> | TabAtkins: You're welcome, thanks for the fast merge. :) |
| 15:31 | <TabAtkins> | ecobos: huh, so applet just didn't do anything any more? |
| 15:32 | <ecobos> | TabAtkins: nope |
| 15:32 | <TabAtkins> | Cool, merged |
| 15:32 | <ecobos> | TabAtkins: thanks! |
| 15:32 | <ecobos> | TabAtkins: (and sorry for nagging :P) |
| 15:33 | <TabAtkins> | Nah, is necessary, thanks |
| 15:33 | <TabAtkins> | I don't keep up with the PRs like I should |
| 15:33 | <ecobos> | TabAtkins: you and fantasai do a great work, I don't know how you keep up tbh |
| 15:34 | <TabAtkins> | The secret is we don't, but we're still productive enough that it's not too noticeable |
| 15:35 | <ecobos> | hah |
| 15:45 | <annevk> | Ms2ger: touché |
| 15:48 | <gsnedders> | TabAtkins: can I prod you to review https://github.com/w3c/web-platform-tests/pull/8822? |
| 18:29 | <railgun> | if there's no objection I can submit a pull request for https://github.com/whatwg/whatwg.org/issues/187 |
| 18:30 | <railgun> | mobile already has consistent padding from what I've seen, this change only affects the desktop version |
| 18:35 | <annevk> | railgun: seems fine to me, it'd be great to have before after screenshots in the PR if not too much trouble |
| 18:35 | <annevk> | railgun: makes reviewing easier |
| 18:35 | <annevk> | Domenic: ^^ |
| 18:36 | <Domenic> | I looked in to this at some point and found weird things where we had some padding but it got overridden or something. Good to fix, but check the nearby code to check if there might be leftovers or weird things. |
| 18:44 | <railgun> | will do (as a side note using a css preprocessor with variables / mixins for padding may have prevented this issue from popping up in the first place) |
| 18:45 | <annevk> | railgun: a lot of this is over a decade old |
| 18:45 | <annevk> | railgun: we could maybe add some CSS variables here and there, now we started using them on the website |
| 19:17 | <railgun> | heh it's been a while |
| 19:17 | <railgun> | I remember when you couldn't use css variables since not all browsers supported it |
| 19:17 | <railgun> | now it seems pretty universal https://caniuse.com/#feat=css-variables |
| 19:20 | <railgun> | actually looking back at it there was little to no browser support when I learned about css variables |