| 00:37 | <MikeSmith> | TabAtkins: good point (about how we can just run the build twice in CI) |
| 10:23 | <MikeSmith> | is the following WebIDL not syntactically valid? |
| 10:23 | <MikeSmith> | https://html.spec.whatwg.org/multipage/workers.html#abstractworker |
| 10:23 | <MikeSmith> | interface mixin AbstractWorker { |
| 10:23 | <MikeSmith> | attribute EventHandler onerror; |
| 10:23 | <MikeSmith> | }; |
| 10:25 | <annevk> | looks correct to me (the language about "implementing" should probably be changed to "includes" though) |
| 10:32 | <MikeSmith> | annevk: OK, I ask because it causes the highlighter to throw with a syntax error |
| 10:33 | <MikeSmith> | and there are 5 other WebIDL blocks from the HTML spec that it also fails on |
| 10:33 | <MikeSmith> | https://github.com/tabatkins/highlighter/issues/4 |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/workers.html#abstractworker |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/interaction.html#elementcontenteditable |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/links.html#htmlhyperlinkelementutils |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement |
| 10:33 | <MikeSmith> | https://html.spec.whatwg.org/multipage/embedded-content.html#htmlimageelement |
| 10:34 | <annevk> | MikeSmith: what's the error? |
| 10:34 | <annevk> | Apart from the last one those are all interface mixins... |
| 10:36 | <MikeSmith> | Exception: IDL SYNTAX ERROR LINE: 2 - skipped: "attribute EventHandler onerror" |
| 10:36 | <MikeSmith> | ...is the error for the https://html.spec.whatwg.org/multipage/workers.html#abstractworker one |
| 10:37 | <MikeSmith> | Exception: IDL SYNTAX ERROR LINE: 2 - skipped: "[CEReactions] attribute DOMString contentEditable" |
| 10:37 | <MikeSmith> | ...for the https://html.spec.whatwg.org/multipage/interaction.html#elementcontenteditable one |
| 10:40 | <MikeSmith> | Exception: IDL SYNTAX ERROR LINE: 62 - skipped: "attribute unrestricted double globalAlpha" |
| 10:40 | <MikeSmith> | ...for the https://html.spec.whatwg.org/multipage/embedded-content.html#htmlimageelement one |
| 10:45 | <annevk> | I checked out Safari favicons, doesn't do SVG |
| 10:45 | <annevk> | Is Firefox really the only browser? I assume it regressed in Opera? |
| 11:47 | <gsnedders> | annevk: I wouldn't guarantee it regressed in Opera, given AFAIK the favicon handling is all in the UI layer? |
| 11:48 | <annevk> | Could be, too lazy to test though |
| 12:08 | <gsnedders> | I don't think I even have Opera installed nowadays :) |
| 17:16 | <annevk> | Domenic: so one thing I was thinking of is that maybe we could have a "document state" object that ends up being 1:1 with Document objects and is created early |
| 17:17 | <annevk> | Domenic: but even that might not quite work if we invoke the parser and such too early |
| 17:17 | <annevk> | Domenic: so much technical debt |
| 17:43 | <Domenic> | annevk: yeah it seems pretty bad. I'm hoping TimothyGu and I can make a dent in some of it this summer, although I am trying to find smaller scoped pieces instead of "fix all of navigation" |
| 17:44 | <annevk> | Domenic: it's all so intertwined which makes it really hard |
| 17:45 | <Domenic> | I think I've found two separable pieces, namely document.open() and javascript: URLs. Each have like 6 open bugs. |
| 17:45 | <annevk> | Domenic: another thing that might be interesting is script execution |
| 17:45 | <Domenic> | What's wrong with script execution? :( |
| 17:46 | <annevk> | Domenic: I wrote a bunch of tests for document.open() and eventually you hit how it opens the HTML parser which is tricky, but yeah (see a lot of outstanding test PRs on that) |
| 17:46 | <annevk> | Domenic: https://github.com/whatwg/dom/issues/575 et al |
| 17:46 | <Domenic> | Ah, right :( |
| 17:46 | <annevk> | Domenic: basically that browsers have some kind of "it's safe to run scripts stack" |
| 17:47 | <annevk> | and some stuff around parser-inserted and moving around documents was also non-interoperable |
| 22:49 | <MikeSmith> | TabAtkins: thanks for the highlighter merges |