| 04:34 | <Domenic> | devsnek: just a bug in our @@asyncIterator implementation right? If so, that's why we write the tests :) |
| 04:34 | <devsnek> | Domenic: yep |
| 04:35 | <Domenic> | I saw your comment about Object.prototype somewhere, that's more of an issue with the test runner/jsdom stuff :-/ |
| 04:36 | <devsnek> | Domenic: what is it doing to my prototypes :-/ |
| 04:37 | <Domenic> | We run the reference implementation in Node.js and the tests inside a jsdom (vm) realm |
| 04:37 | <Domenic> | We should run them both in the vm realm I guess but then we'd need to browserify the reference implementation |
| 04:38 | <Domenic> | See https://github.com/whatwg/streams/blob/cf76fa899a142a6e834049b6ce6c37859bdb5f68/reference-implementation/run-web-platform-tests.js#L55-L64 basically |
| 04:38 | <devsnek> | oof |
| 04:38 | <Domenic> | More yaks to shave |
| 04:40 | <devsnek> | what if you just inject require into the vm |
| 04:42 | <Domenic> | Hmm yeah that might work too |
| 04:43 | <Domenic> | Although I'm not sure, I guess it might depend on whether the require cache contains them or not |
| 11:46 | <annevk> | I'm not really familiar with Blink, but https://chromium-review.googlesource.com/c/chromium/src/+/1264536/2/third_party/blink/renderer/core/frame/csp/content_security_policy.cc seems indicative of some API problem |
| 11:46 | <annevk> | You should never be able to encode something to UTF-8 without the replacement policy... |
| 11:47 | <annevk> | I guess I'll comment on the PR |
| 11:49 | <annevk> | Hmm PR, changeset |
| 12:21 | <gsnedders> | is there any way to distinguish an auxiliary browsing context which has been disowned from any other non-auxiliary top-level browsing context? |
| 12:22 | <annevk> | a) That part of the specification is broken b) Yes |
| 12:22 | <annevk> | You can basically not become non-auxiliary |
| 12:23 | <gsnedders> | b) how? |
| 12:28 | <annevk> | gsnedders: it depends a bit on how we end up defining window name searching, but it's still in the same name group after you set opener to null |
| 12:28 | <annevk> | gsnedders: if we're instead talking rel=noopener then note that would imply creating a new top-level browsing context, not an auxiliary browsing context |
| 12:29 | <annevk> | (and likely also a new "browsing context unit", which is also poorly defined) |
| 12:30 | <gsnedders> | bah, noopener isn't supported in Edge still :/ |
| 12:43 | <gsnedders> | annevk: https://html.spec.whatwg.org/#following-hyperlinks-2 makes it seem like rel=noopener with target=_blank creates an auxiliary browsing context and then immediately disowns it, so should be the same, no? |
| 12:47 | <annevk> | gsnedders: again, that's broken 😃 |
| 12:49 | <gsnedders> | annevk: so what does noopener actually do in impls? :P |
| 12:50 | <gsnedders> | do we have a bug for this? I can't see any searching quickly? |
| 12:53 | <annevk> | gsnedders: hmm, there's multiple |
| 12:54 | <annevk> | gsnedders: https://github.com/whatwg/html/issues/1509 https://github.com/whatwg/html/issues/1826 etc. |
| 12:57 | <gsnedders> | annevk: none of those cover noopener creating a non-auxiliary? |
| 12:59 | <annevk> | The second one does… |
| 13:01 | <gsnedders> | oh, that isn't at all clear :/ |
| 13:06 | <annevk> | Anyway, there are many related issues |
| 13:06 | <gsnedders> | So once all of these are fixed, will you still be able to distinguish disowned auxiliaries? maybe, depending on what exactly named targets do, and what group they look in? |
| 13:07 | <annevk> | gsnedders: what do you mean by disowned? |
| 13:08 | <gsnedders> | annevk: https://html.spec.whatwg.org/#disowned-its-opener |
| 13:09 | <annevk> | gsnedders: that doesn't really help, what matters is what endpoint you are using |
| 13:09 | <annevk> | gsnedders: as I tried to point out before, the spec is broken, so whatever concepts it has are not useful for communication |
| 13:10 | gsnedders | doesn't know how to express the concepts *except* as the spec defines them :( |
| 15:45 | <annevk> | gsnedders: eg, is this about rel=noopener behavior or setting opener? Something else? |
| 15:53 | <gsnedders> | annevk: this is "how using WebDriver can we get something that appears to be the same as a new window/tab opened by a user?" |
| 15:53 | <annevk> | gsnedders: noopener should do that |
| 22:01 | <domfarolino> | Domenic: s/"none"/"omit" in the second line of the commit msg in https://github.com/whatwg/html/pull/3656#issuecomment-427898470 perhaps? |
| 22:02 | <Domenic> | domfarolino: thanks yeah, will edit |