| 04:08 | <MikeSmith> | I’m a bit baffled by how version control for the ES BigInt proposal seems to be handled |
| 04:08 | <MikeSmith> | I raised a pull request against what I assumed is the source at https://github.com/tc39/proposal-bigint |
| 04:09 | <MikeSmith> | the pull request gets merged there, but with a comment: |
| 04:09 | <MikeSmith> | > Thanks for the fix. Can we make sure this is done against the main PR as well? @caiolima |
| 04:09 | <MikeSmith> | https://github.com/tc39/proposal-bigint/pull/206#issuecomment-502538709 |
| 04:10 | <MikeSmith> | oh I see now littledan is actually here |
| 04:11 | <MikeSmith> | I still don’t know what “main PR” means there, though I did go ahead and submit the same patch at https://github.com/caiolima/ecma262/pull/5 |
| 04:11 | <MikeSmith> | I can’t figure out why there are two repos or what the relationship between them is.. |
| 04:15 | <MikeSmith> | botie: inform bkardell congrats on joining Igalia |
| 04:15 | <botie> | will do |
| 05:34 | <Domenic> | MikeSmith: I think the BigInt spec is graduating from incubation, so to speak, so you've caught them in an awkard in-between period. |
| 05:34 | <Domenic> | MikeSmith: what do you mean by having the checker ignore the warnings? In the global deploy.sh script, or only for encoding, or for the checker in general, or...? |
| 05:37 | <MikeSmith> | Domenic: we can do it only for Encoding |
| 05:37 | <MikeSmith> | this is exactly what I made that CHECKER_FILTER environment variable for |
| 05:37 | <Domenic> | That sounds very nice. I guess we added an environment variable we can set in Travis CI? |
| 05:37 | <MikeSmith> | right |
| 05:37 | <MikeSmith> | I’ll try it now |
| 05:38 | <Domenic> | Ah, I misunderstood and thought CHECKER_FILTER was only for file filters, not warning filters. |
| 05:38 | <Domenic> | Thank you |
| 05:38 | <MikeSmith> | cheers |
| 05:38 | <MikeSmith> | Domenic: I guess I should also document somewhere what CHECKER_FILTER is for.. |
| 05:39 | <Domenic> | Yeah I guess the build/ readme in the whatwg.org repo maybe |
| 05:39 | <Domenic> | https://github.com/whatwg/whatwg.org/blob/master/resources.whatwg.org/build/README.md |
| 05:42 | <MikeSmith> | OK |
| 05:51 | <MikeSmith> | damn, running the HTML checker on the Encoding output takes about 3 minutes on my machine |
| 05:51 | <MikeSmith> | makes me wonder if I regressed the performance of the checker somehow |
| 06:02 | <MikeSmith> | Domenic: OK, made the fix locally and it works; will make a patch |
| 06:02 | <Domenic> | \o/ |
| 06:11 | <MikeSmith> | Domenic: https://github.com/whatwg/encoding/pull/179 |
| 06:12 | <Domenic> | Aww frig participation check |
| 06:12 | <MikeSmith> | oh |
| 06:13 | <MikeSmith> | what should we do about that? |
| 06:13 | <MikeSmith> | teh patch doesn’t touch the spec source |
| 06:14 | <Domenic> | Yeah |
| 06:14 | <Domenic> | Sigh |
| 06:14 | <Domenic> | I feel like that should be editor judgement to say it's OK |
| 06:15 | <Domenic> | But I guess I would like to wait for annevk at least to confirm |
| 06:15 | <Domenic> | I would normally like to check with SG but they are quite slow. |
| 06:15 | <MikeSmith> | damn it didn’t work anyway |
| 06:15 | <MikeSmith> | https://travis-ci.org/whatwg/encoding/builds/547557634 |
| 06:16 | <MikeSmith> | why why why |
| 06:16 | <Domenic> | > After the IPR Policy becomes effective, Editors are responsible for ensuring that material included in their Living Standards is governed by a Contributor and Workstream Participant Agreement. |
| 06:16 | <Domenic> | So I think to be sure we are on the up-and-up we should have annevk be the one to say it's OK |
| 06:16 | <MikeSmith> | ah OK that gives the editor discreion |
| 06:16 | <MikeSmith> | yeah |
| 06:17 | <Domenic> | That also makes it pretty clear that not touching the source text means it should be fine |
| 06:17 | <MikeSmith> | yeah |
| 06:17 | <Domenic> | Anyway could it be bash escaping the .*s or something |
| 06:18 | <MikeSmith> | that was not problem when I tested locally |
| 06:18 | <MikeSmith> | I am assuming that doing env:global:CHECKER_FILTER="foo" in .travis.yml will actually propagate to the deploy.sh script when it’s called |
| 06:19 | <MikeSmith> | I mean, the ENCRYPTION_LABEL value does, right? |
| 06:20 | MikeSmith | re-tests locally |
| 06:21 | <MikeSmith> | oh I think I see |
| 06:21 | MikeSmith | tries something |
| 06:30 | <MikeSmith> | space |
| 06:30 | <MikeSmith> | spaces were the cause of the problem |
| 06:30 | <MikeSmith> | will make another patch now |
| 06:51 | <Domenic> | Still doesn't seem to be working, hrm |
| 07:02 | <littledan> | MikeSmith: Yeah, that's what I meant |
| 07:02 | <MikeSmith> | littledan: gotcha, thanks |
| 07:02 | <littledan> | For version control, we don't usually have things so denormalized, it's just because we're almost done |
| 07:05 | <MikeSmith> | littledan: yeah, Domenic said as much just a bit earlier here |
| 07:42 | <MikeSmith> | Domenic: OK, dunno if you still awake, but I made https://github.com/whatwg/whatwg.org/pull/258 to switch the checker invocation to use the --filterfile argument (to read the filter pattern from a file rather than directly from the command line) |
| 07:43 | <Domenic> | MikeSmith: I'm in Tokyo next couple of weeks :). I'm trying to find if any of the repos use FILTER_PATTERN... |
| 07:43 | <MikeSmith> | I thikn they don’t. I checked that yesteday |
| 07:43 | <MikeSmith> | CHECKER_FILTER |
| 07:44 | MikeSmith | does another rg CHECKER_FILTER to double-check |
| 07:45 | <MikeSmith> | yeah OK none do as far as rg claims |
| 08:00 | <MikeSmith> | Domenic: OK, https://github.com/whatwg/whatwg.org/pull/258 updated |
| 08:00 | <Ms2ger> | Domenic, I'm assuming bz is at the Mozilla All Hands, btw |
| 08:01 | <Domenic> | Ah, thanks Ms2ger. |
| 08:21 | <MikeSmith> | Domenic: green |
| 08:21 | <MikeSmith> | https://travis-ci.org/whatwg/encoding/builds/547594227 |
| 08:22 | <MikeSmith> | thanks for the reviews and patience |
| 08:23 | <MikeSmith> | after all that I realize now that probably the cause of the problem with the CHECKER_FILTER variable was that it was being overwritten by the value in the encoding/Makefile file |
| 08:24 | <MikeSmith> | and that’s also what caused it to break when I switched the deploy.sh to using the binary version of the checker rather than the jar |
| 08:25 | <Domenic> | Ahhhh |
| 08:25 | <MikeSmith> | yeah :( |
| 08:25 | <Domenic> | Frigging makefiles, nobody thinks to look there... |
| 08:26 | <MikeSmith> | yeah I dunno how I missed it |
| 08:26 | <MikeSmith> | but anyway with the previsou java -jar invocation, the --filterpattern arg was read by the java command-line-arg parser and had no problem with escaping |
| 08:27 | <Domenic> | That kinda makes sense |
| 08:27 | <MikeSmith> | yeah, with the binary version, I guess it gets parsed by the shell first and some escaping problem happens |
| 08:27 | <MikeSmith> | I guess |
| 08:28 | <Domenic> | OK well I'm heading out for the night, but we need annevk to follow policy anyway, so I think we did our job. Thanks so much. |
| 08:28 | <MikeSmith> | anyway, reading it from a file is more robust for the long term, less error prone |
| 08:28 | <MikeSmith> | ok |
| 08:28 | <MikeSmith> | cheers |
| 08:28 | <MikeSmith> | have a good evening |
| 11:06 | <annevk> | MikeSmith: you still there? |
| 11:06 | <annevk> | MikeSmith: this is about merging https://github.com/whatwg/encoding/pull/179? |
| 11:11 | <MikeSmith> | annevk: heya |
| 11:11 | <MikeSmith> | yeah, that PR |
| 11:11 | <MikeSmith> | needs your OK as editor |
| 11:12 | <MikeSmith> | ..to determine if the Participation Agreement it relevant or not |
| 11:12 | <annevk> | MikeSmith: Meta: commits ought to be fine |
| 11:13 | <MikeSmith> | yeah I would think so |
| 11:13 | <annevk> | Okay, so I need to rebase the RD PR |
| 11:13 | <MikeSmith> | should I explicitly prefix it that way? |
| 11:13 | <annevk> | MikeSmith: I did when landing |
| 11:13 | <MikeSmith> | ah OK thanks |
| 11:14 | <MikeSmith> | and sorry for breaking stuff |
| 11:14 | <annevk> | MikeSmith: no worries |
| 11:15 | <MikeSmith> | the bright side is that this updated setup will be much less prone to breakage going forward |
| 11:25 | <annevk> | MikeSmith: cool, you can land https://github.com/whatwg/html-build/pull/198 yourself right? |
| 11:25 | <annevk> | MikeSmith: or do you want me to do it? |
| 12:10 | <MikeSmith> | annevk: I can |
| 21:08 | <oliverdunk> | I think I'm understanding the fetch spec right, but just to check - is it intended then when fetching a resource with {redirect: "manual"}, the response type is always "cors" (even with Access-Control-Allow-Origin set to *), unless there's a redirect, in which case the response type is "opaqueredirect"? |
| 21:10 | <annevk> | oliverdunk: for same-origin it would not be "cors" |
| 21:11 | <oliverdunk> | annevk: thanks. I did spot that one but luckily it doesn't matter for my use case :) |
| 21:12 | <oliverdunk> | Do you agree for all non same-origin requests? |
| 21:12 | <annevk> | oliverdunk: could be a network error |
| 21:13 | <annevk> | (for various reasons, e.g., the response not implementing the CORS protocol) |
| 21:13 | <annevk> | oliverdunk: also, mode of the request is set to "cors"? |
| 21:17 | <oliverdunk> | Hah, I should've expected thorough answers in a channel like this. Redirect was the only option I was planning on setting, but I can change that. Probably best I explain why I'm asking - I want to detect if a site implements the /.well-known/change-password page, which performs a redirect. Network errors aside, wanted to make sure the behaviour I was seeing was safe to rely on. |