| 03:40 | <MikeSmith> | annevk: about https://bugzilla.mozilla.org/show_bug.cgi?id=1309358 (Add wildcard to Access-Control-Expose-Headers, Access-Control-Allow-Methods, and Access-Control-Allow-Headers), it seems like Florian is on top it? But I will review the changes |
| 03:47 | <annevk> | MikeSmith: yeah think so too, just wanted to let you know as CORS interests you 😊 |
| 03:48 | <MikeSmith> | annevk: yup, thanks, I appreciate it 😀 |
| 03:48 | <MikeSmith> | annevk: https://stackoverflow.com/questions/57412098/does-fetchs-response-body-chunks-correspond-to-http-chunks |
| 03:49 | <annevk> | MikeSmith: no such guarantee |
| 03:50 | <annevk> | MikeSmith: e.g., if there’s a delay after half of an HTTP chunk I’d expect two or so |
| 14:13 | <annevk> | TabAtkins: there's something weird with Shepherd I think |
| 14:13 | <annevk> | TabAtkins: no IDL ref found for {{Window}}: https://travis-ci.org/whatwg/xhr/builds/569858947 |
| 14:13 | <annevk> | TabAtkins: this was working fine a couple hours ago |
| 14:14 | <TabAtkins> | Hm, will check |
| 16:11 | <TabAtkins> | annevk: Looks like Window interface isn't in the spec anymore. I don't see it in the window-object.html page? |
| 16:20 | <Domenic> | We broke all the spec's IDL https://github.com/whatwg/html/issues/4832#issuecomment-519979077 |
| 16:33 | <TabAtkins> | I'm curious if highlighter is failing to return any data, or if something in wattsi is failing on what it was returning. |
| 17:06 | <TabAtkins> | Score one for Bikeshed's test suite, thank you @foolip https://github.com/whatwg/xhr/issues/251 |
| 17:06 | <TabAtkins> | (Only breakage I can find.) |
| 17:08 | <TabAtkins> | annevk or Domenic: ^^^ |
| 17:08 | <TabAtkins> | (I'm on vacation and shouldn't be doing work, but oh well.) |
| 17:18 | <Domenic> | In that case thank you very much for updating the highlighter, TabAtkins. |
| 17:19 | <TabAtkins> | I'm just watching She-Ra this morning, no big interruption. |
| 17:21 | <Domenic> | HTML is now missing HTMLScriptElement for the same reason (readonly attribute DOMString async) |
| 17:22 | <TabAtkins> | Hm, can you instrument to see what exactly highlighter's failure is? |
| 17:22 | <TabAtkins> | Like, is it returning the IDL block, or erroring somehow? |
| 17:26 | <TabAtkins> | Ah, looks like it is a highlighter error, the IDL syntax error is coming out as an Exception. That's a problem on my side, will fix. |
| 17:33 | <TabAtkins> | Domenic: Okay, highlighter just updated again, it'll now just print IDL errors to stdout instead of dying on them, so HTML should get its HTMLScriptElement back. (Just with the async line not highlighted until it's fixed.) |
| 17:34 | <Domenic> | Oh sweet, OK |
| 17:34 | <Domenic> | Well but actually we kind of want to have something in our tooling to detect invalid IDL |
| 17:34 | <Domenic> | So I kind of preferred the old version? We just need to fix Wattsi/html-build to not give exit code 0 if the highlighter fails |
| 17:35 | <Domenic> | Tracked as https://github.com/whatwg/html-build/issues/201 |
| 17:36 | <TabAtkins> | This should be the only thing highlighter outputs to stdout, so presumably you should be able to listen for that. |
| 17:37 | <TabAtkins> | The problem is that highlighter exited entirely on error; an IDL error anywhere would turn off highlighting for the rest of the spec, since wattsi uses highlighter as a daemon. |
| 17:41 | <Domenic> | Ah OK |
| 19:01 | <annevk> | Thanks for fixing that! |
| 19:26 | <smaug____> | Does wpt have something like assert_equals_with_fuzz(some_variable, number, fuzz_value) |
| 19:28 | <smaug____> | perhaps assert_approx_equals |
| 23:34 | <foolip> | TabAtkins: finally, I knew it'd spot something eventually :) |
| 23:48 | <TabAtkins> | Heh, it's spotted stuff before. |
| 23:48 | <TabAtkins> | And always gives me peace of mind when making any involved change. |