| 18:54 | <Michael Ficarra> | this highlighting is a problem: |
| 18:55 | <Michael Ficarra> | we really need to go through and eliminate shadowing in ACs |
| 19:14 | <jmdyck> | It's debateable whether that's shadowing, because it's in an AC, which doesn't 'inherit' any aliases from the surrounding scope, except what's explicitly captured. |
| 19:41 | <Michael Ficarra> | whatever we call it, it's not the same variable but is being highlighted as if it was |
| 19:41 | <Michael Ficarra> | it's not worth the impl effort to have ecmarkup distinguish them, we should just change the name |
| 19:53 | <jmdyck> | Agreed they're distinct variables, but they're bound to the same execution context, so maybe it's okay that they're highlighted at the same time. |
| 20:05 | <shu> | i agree with michael here |
| 20:05 | <shu> | i use the highlighting feature to eyeball use sites |
| 20:05 | <shu> | this is more misleading than helpful |
| 20:08 | <jmdyck> | use of the alias, not use of the EC? |
| 20:16 | <Michael Ficarra> | yeah, definitely |
| 20:16 | <jmdyck> | (well, I was asking shu) |
| 21:24 | <shu> | jmdyck: EC? |
| 21:24 | <shu> | i meant use of aliases is what i most frequently use the highlighting feature for |
| 21:25 | <jmdyck> | EC= execution context. I was asking if "use sites" meant use of the alias, and not use of the thing it referred to. |
| 21:29 | <shu> | oh, yes, i meant use sites of the alias |
| 21:29 | <jmdyck> | ok, thanks. |
| 23:58 | <Michael Ficarra> | ljharb: https://github.com/tc39/ecma262/pull/2877 is rebased and ready to go |
| 23:58 | <bakkot> | it should land as one commit |