| 01:17 | <SimonSapin> | gsnedders: for html5lib, should I rather comment on critic? |
| 11:25 | <gsnedders> | SimonSapin: I think jgraham would say yes. I typically don't care until I end up rebasing the branch and then losing all review comments from the PR. |
| 11:27 | <SimonSapin> | that’s for comment on diff lines, comments on the PR itself don’t get lost |
| 11:27 | <SimonSapin> | but still, fragmenting the discussion is not great |
| 11:28 | <gsnedders> | SimonSapin: Yes, I know. It's still sub-optimal, as it makes it hard to see whether the comments I made before have actually been addressed, in my experience. |
| 12:04 | <gsnedders> | Yay everything on Travis-CI fails because Genshi cannot be securely downloaded! :( |
| 12:24 | <gsnedders> | https://github.com/html5lib/html5lib-python/issues/138 |
| 12:25 | <gsnedders> | Anyone who has opinions on sanitizing HTML, please do look. (Is tel: safe?) |
| 12:28 | <jgraham> | SimonSapin: Yes, please comment on critic. GitHub is just sadness for tracking comments that need to be addressed |
| 12:32 | <gsnedders> | jgraham: https://github.com/html5lib/html5lib-python/pull/139 will block everything once Travis CI updates to pip 1.5 |
| 12:33 | <jgraham> | gsnedders: I'm on it |
| 12:34 | <jgraham> | Why do you need --allow-external Genshi? |
| 12:35 | <gsnedders> | jgraham: It's not hosted on PyPI. It has to scrape the download page to find it. And needs allow-unverified as it does this over HTTP, and has no hash to verify the download against. |
| 12:36 | <jgraham> | Sweet jesus |
| 12:36 | <jgraham> | Can we file a bug against Genshi on this? |
| 12:36 | <gsnedders> | http://genshi.edgewall.org/ticket/581 sort of does. |
| 12:37 | <gsnedders> | I nagged them about it before, to no avail, when it was first decided pip was going to change to do this. |
| 12:37 | <jgraham> | Ah, you already filed it |
| 12:38 | <jgraham> | r+, please rebase onto master |
| 12:42 | <jgraham> | SimonSapin: Can you review https://critic.hoppipolla.co.uk/1c27075e?review=521 please? |
| 12:43 | <jgraham> | Was iana_parse just unused code? |
| 12:44 | <gsnedders> | jgraham: It was in utils for a reason. Used to generate the encodings dict in constants.py. |
| 12:45 | <jgraham> | Oh |
| 12:46 | <jgraham> | Fair enough |
| 12:46 | <SimonSapin> | jgraham: I can, as soon as I figure out how to in critic |
| 12:47 | <gsnedders> | (Am about to push #123). |
| 12:48 | <gsnedders> | jgraham: Are you going through all the open PRs? |
| 12:48 | <jgraham> | SimonSapin: If you think the changes are OK, you just mark the file as reviewed without creating any issues |
| 12:48 | <jgraham> | SimonSapin: And then press "submit" |
| 12:48 | <jgraham> | In critic issues and review progress are orthogonal |
| 12:48 | <gsnedders> | jgraham: I think his first comment on GH is enough. |
| 12:49 | <jgraham> | gsnedders: I haven't seen the GH comment |
| 12:49 | <gsnedders> | jgraham: (to show that it isn't okay) |
| 12:49 | <gsnedders> | jgraham: On the PR, not on any commit. |
| 12:50 | <jgraham> | SimonSapin: To create an issue click on the line that has the issue and add a comment when prompted |
| 12:55 | <jgraham> | gsnedders: Nothing so organised |
| 12:56 | <gsnedders> | jgraham: Go through the ones I've submitted, at least? Most of them have some comment giving status. |
| 12:56 | <jgraham> | gsnedders: Numbers? |
| 12:56 | <jgraham> | (right now I am going to go and change the pedals on my bike…) |
| 12:57 | <gsnedders> | jgraham: #125, #108, #95, and possibly #110 and #93 |
| 12:57 | <gsnedders> | jgraham: By #125 I mean #130 |
| 13:08 | <gsnedders> | I hate all the input stream code :( |
| 14:17 | <jgraham> | And by 130 you mean 479? |
| 14:29 | <jgraham> | gsnedders: r/227 seems to be wiating for you |
| 16:36 | <jgraham> | """These tests are written by Björn Höhrmann, and do not match the specification. |
| 16:36 | <jgraham> | They are licensed under GPLv3 and Artistic 2.0. |
| 16:36 | <jgraham> | """ |
| 16:36 | <jgraham> | rm -rf then |