| 01:44 | <JonathanNeal> | I’m trying to test an update to my Promises polyfill, and I’d like to run it through Promises/A+ Compliance Test Suite. Has anyone done this using browserify? There aren’t specific instructions, and I’m a bit of a novice. |
| 01:52 | <caitp-> | do the aplus tests run in a browser? |
| 01:54 | <JonathanNeal> | Supposedly, with browserify https://github.com/promises-aplus/promises-tests > This also works in the browser, if you have your Mocha tests running there, as long as you use browserify. |
| 01:56 | <JonathanNeal> | But I might just take the tests at, say, https://github.com/promises-aplus/promises-tests/blob/master/lib/tests/2.1.2.js and port them to straight up mocha if I can’t figure it out. Kind of a lame solution, but I’m eager to see if I’ve done things right. |
| 02:18 | <caitp-> | i dunno, haven't run them in the browser |
| 02:18 | <caitp-> | we should probably do that |
| 02:32 | <JonathanNeal> | thanks for the credit/blame |
| 02:33 | <JonathanNeal> | caitp-: are you on the angular team? |
| 02:34 | <caitp-> | yeah |
| 02:36 | <JonathanNeal> | oh sweet, i saw the angular 1.3 v 2.0 video and it looked good, simplified, which are usually === anyway |
| 02:38 | <caitp-> | thats definitely what i want us to do with it, simplify the crazy |
| 03:17 | <JonathanNeal> | I just confused my synthetic console in IE8 for Chrome’s. Yay and boo. |
| 04:07 | <JonathanNeal> | caitp-: i’m porting the tests to mocha, is that the testing suite you use? |
| 06:23 | <yoav> | TabAtkins: Around by any chance? |
| 08:19 | <annevk> | wanderview: could have answered that question yesterday I guess, oh well |
| 09:53 | <annevk> | tobie: closely watching GitHub or are you a bot? |
| 11:01 | <annevk> | gsnedders: jgraham: I created a new encoding directory |
| 11:02 | <annevk> | gsnedders: jgraham: however, I now want to write a couple simple gbk / gb18030 tests, is it okay if I do that in a separate branch? |
| 11:02 | <annevk> | gsnedders: jgraham: that I guess would also introduce this new directory |
| 11:02 | <annevk> | gsnedders: jgraham: or should I branch from the previous branch? |
| 11:03 | <annevk> | gsnedders: jgraham: or... just add it to the previous branch and make the PR ever larger? |
| 11:06 | <annevk> | For now I'll continue to create files in this iso-2022-jp branch as that's easiest |
| 12:43 | <Domenic> | JonathanNeal: the tests are already written in Mocha; not sure what you mean |
| 12:46 | <annevk> | zcorpan: were you suggesting we should align with Chromium/WebKit on encoder error handling? |
| 12:46 | <annevk> | zcorpan: kind of leaning in that direction too now |
| 12:46 | <annevk> | zcorpan: since Firefox emits UTF-8 bytes |
| 12:48 | <annevk> | jgraham: how do I get my /etc/hosts file shared with the VM? |
| 12:50 | <Domenic> | caitp: it should work with any thenables that follow Promises/A+. Last I checked Angular 1.3 was fixed so that it didn't depend on the digest cycle and so chai as promised should work with it |
| 13:22 | <Ms2ger> | annevk, tobie's a bot |
| 13:26 | <Ms2ger> | annevk, and I think a separate branch would be easier; if you're working on the existing branch, you can do git checkout -b gbk; git rebase -i origin/master and drop the iso-jp commit |
| 13:28 | <tobie> | annevk, Ms2ger: bot is indeed usurping my identity on web-platform-tests. |
| 13:29 | <tobie> | *a bot |
| 14:13 | <MikeSmith> | annevk: those tobie added foo labels messages are from a bot (that tobie set up) |
| 14:14 | <MikeSmith> | oh |
| 14:15 | MikeSmith | only now sees that Ms2ger and tobie both said the same thing earlier. I guess I should read the scrollback first.. |
| 14:21 | <annevk> | Ms2ger: completely separate or on top of iso-2022-jp? |
| 14:21 | <annevk> | Ms2ger: I guess completely separate can work, I'll let you know when I'm ready |
| 14:28 | <Ms2ger> | annevk, yeah, completely separate makes the most sense, I think |
| 15:05 | <annevk> | zcorpan: never mind, it seems we already decided that Gecko needed to align with Chromium and WebKit |
| 15:30 | <MikeSmith> | annevk: I can review those iso-2022-jp tests if Ms2ger or Simon don't get to it first |
| 15:30 | <MikeSmith> | but probably not before Monday my time |
| 17:19 | <annevk> | MikeSmith: not in a rush, thanks |
| 17:41 | <Ms2ger> | MikeSmith, if you have anything of those encodings paged in, I'll be happy to stand down :) |
| 19:58 | <annevk> | Messed up rebranching :-( |
| 22:53 | <JonathanNeal> | Domenic: Oh, I see, that explains why it was so easy. I’ve only needed to tweak things here and there to test them in the browser. |
| 22:57 | <Domenic> | JonathanNeal: https://github.com/domenic/aplus-tests-against-the-browser/tree/gh-pages might be interesting |
| 22:58 | <Domenic> | JonathanNeal: the gh-pages branch isn't working now for some reason, not sure why |
| 22:59 | <JonathanNeal> | Maybe it’s easier to show you what I mean. I’m really not trying to change much https://gist.github.com/jonathantneal/aecbb62eacb4fecd1123 |
| 23:02 | <Domenic> | JonathanNeal: the adapter pattern was meant to avoid having to modify the test code |
| 23:02 | <Domenic> | JonathanNeal: https://github.com/domenic/aplus-tests-against-the-browser/blob/gh-pages/index.html#L15-L26 |
| 23:31 | <jgraham> | annevk: I assume you set the hosts file in the VM |
| 23:43 | <JonathanNeal> | Domenic: that makes sense. Know why the gh-pages branch might not be working? |
| 23:57 | <Domenic> | JonathanNeal: probably something about how I messed with my blog URLs... |