| 01:08 | <devsnek> | is built-ins/TypedArrayConstructors/internals/DefineOwnProperty/tonumber-value-detached-buffer.js correct? |
| 01:09 | <devsnek> | the spec steps listed in it do not match the spec |
| 01:13 | <devsnek> | oh nvm i see the change is actually in IsValidIntegerIndex |
| 01:15 | <devsnek> | but now a bunch of other tests fail |
| 01:18 | <devsnek> | oh nvm there was a typo |
| 07:46 | <sideshowbarker> | Where does the spec define that a number literal can have a sign? |
| 07:46 | <sideshowbarker> | context is https://github.com/mdn/content/pull/6379 |
| 09:49 | <sideshowbarker> | looking at https://github.com/mdn/content/issues/6382 |
| 09:50 | <sideshowbarker> | The |
| 09:51 | <sideshowbarker> | returns a shallow copy is not true, right? |
| 09:56 | <Ashley Claymore> | "returns a shallow copy" is correct |
| 09:56 | <sideshowbarker> | ah OK |
| 09:57 | <sideshowbarker> | so then I am just not understanding what I’m seeing when I try it |
| 09:58 | <sideshowbarker> | if I try the OP’s test case in that issue, it seems like I’m in fact getting a deep copy rather than a shallow one |
| 09:59 | <sideshowbarker> | that is, simply this: |
| 10:00 | <sideshowbarker> | if I examine z, it does seem to have kept that [1,4,5] array as a member |
| 10:02 | <Ashley Claymore> | |
| 10:05 | <Ashley Claymore> | it hasn't copied [1,4,5], but kept the original 'instance' |
| 10:15 | <sideshowbarker> | OK, I see |
| 10:20 | <Ashley Claymore> | NumericLiterals don't have signs: https://262.ecma-international.org/12.0/#sec-literals-numeric-literals+ and - are separate unary operations. This can also be seen here: https://astexplorer.net/#/gist/9e46bdbeb90384aa6fae4381538f29da/a8def7d99cb5a1e8f9e848c698cb03b23042cffa |
| 10:22 | sideshowbarker | looks |
| 10:26 | <sideshowbarker> | Ashley Claymore: so what we have in the examples in MDN at http://localhost:5000/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#numeric_literals is strictly wrong? |
| 10:26 | <sideshowbarker> | oofs make that https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#numeric_literals |
| 10:27 | <sideshowbarker> | Some examples of numeric literals are: |
| 10:29 | <sideshowbarker> | And so I should remove that -345 but add a statement saying something like, “A number literal can be preceded by a - or + sign to give it a sign.” |
| 10:30 | <sideshowbarker> | or “to assign it a sign”? |
| 10:32 | <Ashley Claymore> | Yep, -345 is not a technically correct example of a numeric literal |
| 10:33 | <sideshowbarker> | OK — thanks |
| 14:58 | <jmdyck> | Hm. I just tried to push a branch of ecma262 to my personal github repo, and got "! [remote rejected] ... (refusing to allow a Personal Access Token to create or update workflow .github/workflows/build.yml without workflow scope)" |
| 15:00 | <jmdyck> | I'm guessing this is related to the merge of #2260 on Friday aft. |
| 15:03 | <jmdyck> | ljharb: ? |
| 15:15 | <jmdyck> | I was able to push my branch by deleting everything in .github/workflows, but that seems like a bad solution. |