| 05:48 | <ljharb> | jmdyck: is your personal repo's master branch up to date? |
| 13:43 | <jmdyck> | ljharb: Attempting to push an up-to-date master branch to my personal repo fails similarly. |
| 13:45 | <jmdyck> | but updating master on github seems to work. |
| 13:46 | <jmdyck> | And that seems to allow pushing other branches. |
| 13:55 | <jmdyck> | And I've now backed out the workflow deletions from 2445. |
| 13:55 | <jmdyck> | Thanks! |
| 15:03 | <shu> | hey folks, pattern matching incubator call happening right now in case folks forgot |
| 15:10 | <shu> | second update: cancelling, folks didn't show, might've not seen the finalized time since i finalized it kinda late last week. also didn't get a satisfying answer yet to mark's question of who outside the champion group would like to participate |
| 15:10 | <shu> | will update the reflector thread |
| 15:26 | <jmdyck> | So now I'm getting GitHub workflow email, for both jmdyck/ecma262 and tc39/ecma262. |
| 15:45 | <ljharb> | i think that’s expected; GitHub actions is a bit email-happy |
| 15:45 | <jmdyck> | I can mostly see what it's about, but I'm puzzled by one set |
| 15:46 | <jmdyck> | where the subject is "[tc39/ecma262] PR run failed: Upload Preview - merchant-center-1546635176041 (80efe41)" |
| 15:46 | <jmdyck> | what the heck is "merchant-center-1546635176041" ? |
| 15:47 | <jmdyck> | I don't have a branch or PR with that name. |
| 15:51 | <ljharb> | hm - does anyone? |
| 15:52 | <ljharb> | the upload preview task runs on tc39/ecma262 when any pull request finishes the “build preview” step |
| 15:52 | <ljharb> | since you have write access, you might receive an email like that for every PR |
| 15:53 | <jmdyck> | Shouldn't the email tell me which PR or branch it's trying to do the upload preview for? |
| 15:54 | <ljharb> | I’d think so, but the way workflow_run tasks work is that that info is all buried in an event payload |
| 15:58 | <jmdyck> | Apparently the Upload Preview job is failing because scripts/publish-preview throws "ReferenceError: Missing env var PULL_REQUEST" |
| 16:06 | <jmdyck> | But workflows/preview.yml does appear to be setting the PULL_REQUEST env var for the run of publish-preview. |
| 16:06 | <jmdyck> | So is the problem that ${{ github.event.workflow_run.pull_requests['0'].number }} isn't defined? |
| 16:15 | <ljharb> | yes, that's the issue i'm working through right now with it |
| 16:15 | <ljharb> | it was defined when i was testing on my fork, but it seems not to be now, so i need to find another way to convey it |
| 19:31 | <Aki> | someone wanna update this citation (which currently points to a 404) to something else? https://en.wikipedia.org/wiki/ECMAScript#cite_note-ES2021-9 does ES2021 have a permalink on Ecma's site? should it link to https://www.ecma-international.org/news/ecma-international-approves-new-standards-4/ ? |
| 19:34 | <jmdyck> | I'd say the permalink is https://262.ecma-international.org/12.0/ |
| 19:37 | <jmdyck> | Seems like the url that's there (http://www.ecma-international.org/ecma-262/12.0/) should work, but Ecma hasn't set up the redirect. |
| 19:47 | <jmdyck> | I'll do some fixing. |
| 20:11 | <shu> | bakkot: did you see https://github.com/lucacasonato/proposal-binary-encoding? |
| 21:02 | <shu> | i am getting increasingly dissatisfied with reviewing spec stuff on GH |
| 21:02 | <shu> | it really is quite bad for large documents like ours |
| 23:06 | <bakkot> | shu: yeah, https://github.com/bakkot/proposal-arraybuffer-base64/issues/4 |
| 23:13 | <shu> | good to see quick engagement |