08:18 | <Noam Rosenthal> | Hi annevk! I rebased me HTML/FETCH/RT integration from before the holidays and have a few PRs pending if you can add them to your queue. |
08:22 | <Ms2ger ππ> | annevk: hey, quick question about test changes for my Exposed PRs. Would you like me to prepare wpt PRs with the IDL changes ported over manually, or could I wait until the bot lands them and add the code to test against ShadowRealms afterwards? |
08:52 | <annevk> | foolip: thoughts on Ms2ger ππ's question? I guess it's fine either way? |
08:52 | <foolip> | Ms2ger ππ annevk I think it's fine to just wait for them to come via an @webref/idl update. |
08:53 | <foolip> | Ms2ger ππ: thanks for merging https://github.com/web-platform-tests/wpt/pull/31873! |
08:54 | <foolip> | Ms2ger ππ: oh, it broke some of the tests though: https://wpt.fyi/results/geolocation-API/idlharness.https.window.html?diff&filter=ADC&run_id=5741853509943296&run_id=5635100688515072 |
08:54 | <Ms2ger ππ> | Huh, I thought I checked, sorry |
08:54 | <foolip> | Ms2ger ππ: for these PRs one needs to look at the wpt.fyi checks if there are gray boxes |
08:54 | <Ms2ger ππ> | Will fix in a sec |
08:55 | <foolip> | The checks don't fail because it's not disallowed to introduce failing tests, after all. But it results in a confusing situation. |
08:57 | <Ms2ger ππ> | https://github.com/web-platform-tests/wpt/pull/32425 |
09:00 | <Ms2ger ππ> | https://github.com/web-platform-tests/wpt/pull/32426 |
09:57 | <foolip> | Who wants less noise in new PRs? https://github.com/web-platform-tests/wpt/pull/32427 |
10:21 | <foolip> | It's funny that we added Dependabot for code that hasn't been touched since 2013 :) https://github.com/web-platform-tests/wpt/pull/32428 |
10:32 | <Andreu Botella (he/they)> | Hey, it looks like the HTML spec lists the contextmenu event in the list of events, but that event is not fired from anywhere in the spec |
10:32 | <Andreu Botella (he/they)> | It seems like before https://github.com/whatwg/html/pull/2742 there was spec text defining when to fire it, but I'm not sure if removing it was a bug, or if that text actually moved to some other spec |
10:34 | <Andreu Botella (he/they)> | All browsers fire the event on right-click, so the discussion about planned browser support arguments clearly only applies to the <menu> element, not to the contextmenu event |
10:42 | <annevk> | Yeah, agreed. That should probably be restored or moved to UI Events. |
10:42 | <Andreu Botella (he/they)> | Also, while looking into this I noticed that the dfn panels in commit snapshots of the HTML spec reflect the latest commit, not the commit snapshot |
10:43 | <Andreu Botella (he/they)> | it's looking for /xrefs.json |
10:44 | <Andreu Botella (he/they)> | huh, the commit snapshots don't actually have a xrefs.json file π₯ |
15:59 | <Domenic> | |
17:29 | <Domenic> | annevk: want to do an editorial pass on https://github.com/whatwg/html/pull/7361 or happy with emilio's review? |
17:48 | <Luca Casonato> | annevk Could take a look at https://github.com/whatwg/spec-factory/pull/35 some time this week? |
18:36 | <smaug> | I don't understand this algorithm: https://html.spec.whatwg.org/#rendered-text-fragment Steps 3.2 and 3.3 append to /fragment/ but what is that /fragment/ ? |
18:37 | <smaug> | Is it missing some step where DocumentFragment should be created? Or perhaps I just didn't notice it. |
18:38 | <smaug> | https://dom.spec.whatwg.org/#converting-nodes-into-a-node is a bit similar, but it has explicit DocumentFragment creation |
18:48 | <TabAtkins> | That's an algo bug, yeah. That variable is never initialized. |
20:04 | <Andreu Botella (he/they)> | Would https://github.com/whatwg/html/issues/7505 be editorial? |
20:25 | <sideshowbarker> | Were you in a secure context? |
20:43 | <Andreu Botella (he/they)> | Domenic: Come to think of it, I should've kept the ID of the dfn |
20:43 | <Andreu Botella (he/they)> | Should I open a new PR? |
20:54 | <Domenic> | Andreu Botella (he/they): IMO it's OK to lose it, unless someone complains or we know of prominent instances linking to it. |
20:55 | <Andreu Botella (he/they)> | https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event links to it, but I'm about to open a PR to change it |