02:52 | <Alexander Kalenik> | hey, I ran into issue but not sure if it is fetch spec, navigables spec or me missing something: Step 19.6 in https://html.spec.whatwg.org/multipage/browsing-the-web.html#create-navigation-params-by-fetching but when I look into fetch spec it seems like processing of the next manual redirect cannot result in calling processResponse callback because, according to the fetch spec:
https://fetch.spec.whatwg.org/#fetch-finale which is the only place that calls processResponse callback is never reached while processing manual redirect because main fetch did early return because redirect=true param is passed by "HTTP-redirect fetch". am I missing something? |
04:16 | <Alexander Kalenik> | I checked fetch spec commit history and in the past instead of "Return the result of running main fetch given fetchParams and true." there was "Return the result of performing a main fetch using request with recursive flag set if request's redirect mode is not manual". Specifying recursive=false if redirect mode is not manual solves the problem that I described above. Not sure why this addition has been removed from spec. Commit that changed the line https://github.com/whatwg/fetch/commit/12dd6fa8ca76bd3bdff0c65a0c5a84b3ca870c3d |
16:47 | <Dominic Farolino> | Hmm, I think you're right. It seems like HTTP-redirect fetch should not unconditionally call main fetch with "true", and if that's right, then I think this sentence is also wrong: https://fetch.spec.whatwg.org/#ref-for-process-response%E2%91%A2. |
18:26 | <Alexander Kalenik> | Hmm, I think you're right. It seems like HTTP-redirect fetch should not unconditionally call main fetch with "true", and if that's right, then I think this sentence is also wrong: https://fetch.spec.whatwg.org/#ref-for-process-response%E2%91%A2. |
20:03 | <Dominic Farolino> | I think your logic is sound. Changing the last line of http-redirect-fetch to what it used to be seems good, but (1) I'm not sure if doing so would have any unwanted side effects from the steps that would run after https://fetch.spec.whatwg.org/#ref-for-fetch-params-process-response%E2%91%A0, or (2) if the change to the current state was intentional and I'm just missing something ;) Anne is the expert here. |