| 14:39 | <annevk> | zcorpan: so weird how naturalHeight returns the density-corrected natural height, that's just confusing af |
| 15:59 | <awesomekling> | Noam Rosenthal: heyo! I'm integrating https://github.com/whatwg/fetch/pull/1645 in our fetch implementation, could you help me understand why we don't use the internal response for processResponse, and only for processResponseConsumeBody? |
| 16:00 | <zcorpan> | annevk: https://github.com/ResponsiveImagesCG/picture-element/issues/247 - but the irc log is no longer available and wasn't indexed in waybackmachine |
| 16:09 | <annevk> | awesomekling: we only use it to collect the response body, right? I think if we only passed the internal response the caller wouldn't have access to the opaque response, which could be bad as they wouldn't have sufficient information to make the correct security decision |
| 16:10 | <annevk> | awesomekling: e.g., whether it's CORS-same-origin |
| 16:11 | <Noam Rosenthal> | awesomekling: that's a good question, more for annevk. The way I see it internal response is a mechanism to make sure that invokers of no-cors fetch know that they're dealing with hot unsafe stuff. But I'm not sure it's a good mechanism for that, as the invoker probably wants the data anyway and most HTML callers hide this using "unsafe response". We relaxed it for processResponseConsumeBody because it's the less "advanced" callback but I'm not sure if we should keep it for the other callbacks. |
| 16:12 | <awesomekling> | annevk: hmm, all right. I'm trying to work out if https://github.com/whatwg/html/issues/9066 is "solvable" now, or if there are more bits needed |
| 16:33 | <annevk> | awesomekling: Noam Rosenthal: looking at the spec again I think we did it wrong; "internalResponse and nullOrBytes" should have been "response and nullOrBytes" |
| 16:33 | <annevk> | Same for the one below. |
| 16:34 | <annevk> | We have to use the internal response after all to actually get all the bytes, but we don't have to use the internal response for the first argument and it's safer not to. |
| 16:34 | <annevk> | I'll put up a PR. |
| 16:44 | <annevk> | awesomekling: Noam Rosenthal: https://github.com/whatwg/fetch/pull/1661 |