| 06:38 | <zcorpan> | Landing Noam's stack first seems easier wrt rebasing |
| 08:08 | <Noam Rosenthal> | Also I found some cases where I think this PR doesn't cover, added a comment |
| 08:53 | <annevk> | That's the wrong PR for that comment I think? |
| 09:05 | <annevk> | Also, that's technically not a case you can reach per spec because we don't have sync pagehide, but in practice we do have sync pagehide of course. I'll add a tentative test for that as well. |
| 09:13 | <Noam Rosenthal> | https://github.com/whatwg/html/pull/12708#issuecomment-5319853865 ? |
| 09:19 | <Noam Rosenthal> | We should probably fix https://github.com/whatwg/html/issues/10194 or change the spec to reflect reality |
| 09:35 | <Noam Rosenthal> | or just have a global "chrome" property on window that does all kinds of things |
| 10:28 | <Noam Rosenthal> | https://github.com/whatwg/html/pull/12794 |
| 11:06 | <annevk> | Yes we should. Note that 12709 covers AAA (and also covers the pagehide scenario now, I also updated WPT with a tentative test). |
| 11:07 | <Noam Rosenthal> | Great looks good now! |
| 11:08 | <Noam Rosenthal> | ah it's two different PRs, I thought the second one was the tests |
| 11:30 | <annevk> | Note that there's also a second test PR: https://github.com/web-platform-tests/wpt/pull/61398 |
| 11:51 | <Noam Rosenthal> | Thanks! https://chromium-review.git.corp.google.com/c/chromium/src/+/8261279 fixes some of this in blink |
| 14:12 | <annevk> | Noam Rosenthal: some more tests that require further spec changes (Chromium already gets these right): https://github.com/web-platform-tests/wpt/pull/62020 |
| 14:14 | <Noam Rosenthal> | noice |
| 14:32 | <annevk> | I'm going to merge them into 12708 I think. And then tomorrow I'll try to review your four PRs. |
| 14:34 | <Noam Rosenthal> | hsivonen, zcorpan, are you OK with landing https://github.com/whatwg/html/pull/11818? It's been up for a month waiting for additional review (understood since folks were OOO etc, but maybe it's time to move forward...) |
| 14:55 | <Noam Rosenthal> | SG! |
| 15:03 | <Noam Rosenthal> | Once there are less PRs in flight I want to do a big parser cleanup, specifically around having a parser instance with the different things associated with it, and specifying the type of an "insertion location" |
| 15:29 | <Shannon Booth> | speaking of PRs, is there any chance #12127 and #12391 could please get a look? been open for a little and i think ready (maybe just queued in the backlog though) |
| 16:17 | <Noam Rosenthal> | I gave these an unofficial review, they look good |