| 11:50 | <botie> | a-ja, at 2017-07-10 04:12 UTC, MikeSmith said: I added scope/updateviacache/workertype support to the checker sources and pushed to https://checker.html5.org/ & https://validator.w3.org/nu/ I also added some filtering for now to suppress the warning about child-src |
| 18:04 | <domfarolino> | Domenic: for my PR on HTML you commented on a bit ago, if I pull those inner steps out into its own algorithm would it be worth putting a <p class=note> underneath the first step of the innerText algorithm saying this is codifying some legacy behavior etc? |
| 18:05 | <Domenic> | domfarolino: I don't know if I'd go as far as to call it legacy behavior. But maybe an example showing how it can sometimes be surprising would be helpful. |
| 18:05 | <domfarolino> | Domenic: cool! Yeah I like that |
| 19:25 | <jolvera> | Domenic just saw the last edits on the search bar PR, most of the changes was me trying to match style of the old version |
| 19:25 | <jolvera> | might be worth to have a style guide for js/css code? |
| 19:25 | <Domenic> | jolvera: yeah no problem, just cleaning it up a bit since now we're maintaining it instead of the previous author |
| 19:25 | <Domenic> | jolvera: yeah I think that would definitely be a good idea |
| 19:25 | <Domenic> | jolvera: currently I'm trying to hack it to see if it's possible to just use focus instead of manipulating .selected, but so far it isn't working. So probably will merge very soon. |
| 19:26 | <jolvera> | Domenic i already spent some time trying to do that |
| 19:26 | <Domenic> | haha dang I should have asked |
| 19:26 | <jolvera> | couldn't figure it out, lol |
| 19:28 | <jolvera> | for a style guide, it could be something really simple, e.g. https://github.com/bower/bower/wiki/Style-Guide |
| 19:28 | <jolvera> | stating most common use cases |
| 19:35 | <Domenic> | I think I got the focus thing |
| 19:43 | <Domenic> | jolvera: changes uploaded, would love your review |
| 19:43 | <jolvera> | checking now |
| 19:44 | <Domenic> | The other thing I'm wondering about is how in Firefox / does not work, hmm |
| 19:44 | <Domenic> | On the other hand searching the internet for ways to override reveals at least one user who is frustrated that overriding it is possible |
| 19:44 | <Domenic> | Maybe we'll just leave it |
| 19:45 | <Domenic> | The alternative is UA sniffing to not install the placeholder="" in Firefox I guess |
| 19:52 | <jolvera> | yup |
| 19:53 | <jolvera> | what about to add outline: none to the focus element |
| 19:53 | <jolvera> | it looks weird with the blue box-shadow on chrome and the green background |
| 19:53 | <Domenic> | I am not a big fan of doing that as it apparently makes it inaccessible |
| 19:54 | <Domenic> | We maybe could color it green? |
| 19:55 | <jolvera> | maybe, i mean, is not big deal |
| 19:55 | <Domenic> | https://www.tjvantoll.com/2013/01/28/stop-messing-with-the-browsers-default-focus-outline/ |
| 19:56 | <Domenic> | Hmm I guess we have alternative styles so maybe it's fine |
| 19:57 | <Domenic> | I am leaning toward leaving it |
| 20:15 | <jolvera> | yeah, just leave it as is |
| 20:15 | <jolvera> | s/lets just/just/ |
| 20:16 | <jolvera> | Domenic everything else looks good! |
| 20:17 | <wanderview> | Domenic: do you agree with my review of changes to response-stream-disturbed-5.html here? https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1128959&attachment=8885814 |
| 20:26 | <Domenic> | wanderview: yes, agreed |
| 20:51 | <wanderview> | thanks |
| 23:57 | <MikeSmith> | TabAtkins: should I add support to the HTML checker for the 'hover' media feature? |
| 23:57 | <MikeSmith> | https://github.com/validator/validator/issues/536 |
| 23:58 | <MikeSmith> | and if so, should I also add support for 'any-hover', 'pointer', and 'any-pointer'? |
| 23:58 | <TabAtkins> | Yeah |
| 23:58 | <MikeSmith> | OK |