| 00:00 | <railgun> | no I haven't seen this |
| 00:00 | <TimothyGu> | oh yeah that's the repo containing the tools for building |
| 00:00 | <railgun> | so if I just follow the instructions I should have a version like the one on the site? |
| 00:00 | <TimothyGu> | railgun: yup |
| 00:01 | <TimothyGu> | clone html-build alongside html |
| 00:01 | <TimothyGu> | it'll find your source file automatically |
| 00:02 | <ska> | I'm trying to use this https://github.com/widget-/slack-black-theme but I'd like to use a local copy of that fetch() url. |
| 00:30 | <railgun> | TimothyGu: just tried html-build and it worked, thanks! |
| 01:38 | <railgun> | would be helpful if the wattsi readme was updated with a reminder that you need to add bin/wattsi to your path |
| 01:39 | <TimothyGu> | railgun: yay! |
| 01:44 | <railgun> | TimothyGu: mind if I submit a pull request? wattsi makes things a lot faster too, so I think the README should be more straight-forward |
| 01:45 | <TimothyGu> | railgun: go ahead. I don't maintain wattsi though |
| 01:49 | <railgun> | ok, thanks for the tips btw, this is a lot better than what I was doing before |
| 02:04 | <railgun> | is this correct for issue #3441? https://i.imgur.com/0IVBCwX.jpg cc: annevk |
| 03:42 | <MikeSmith> | PSA for those who like Dockerfiles: I created a Dockerfile of the HTML checker and put it on Docker Hub |
| 03:42 | <MikeSmith> | https://hub.docker.com/r/validator/validator/ |
| 03:45 | <Domenic> | Oooh |
| 03:46 | <Domenic> | I wonder if that'd be faster than downloading the jar |
| 03:46 | <Domenic> | Probably similar |
| 03:47 | <MikeSmith> | yeah though I guess Dockerhub has caches and uses a CDN |
| 03:49 | <MikeSmith> | the slowest part of running it is actually a part that calls "gpg --recv-keys" to get my gpg key and check the gpg sig for the downloaded jar |
| 03:50 | <MikeSmith> | which is probably overkill because I also have it checking the SHA1 sum for ot |
| 03:50 | <Domenic> | railgun: that looks like a good start. Missing an OffscreenCanvas <dt> (you can have multiple <dt>s for a given <dd>), and need to use <code> inside the <dt>s |
| 04:10 | <railgun> | Domenic: just rebased against master and added the <dt> for OffscreenCanvas |
| 04:10 | <Domenic> | railgun: great! Feel free to submit a PR so we can review |
| 04:12 | <railgun> | sure I'll submit it as soon as I add <code> inside the <dt>s |
| 04:16 | <railgun> | no <code> for otherwise right? |
| 04:22 | <Domenic> | Right |
| 04:36 | <railgun> | just made the PR https://github.com/whatwg/html/pull/3463 Domenic: can you verify me? |
| 04:36 | <Domenic> | railgun: I'll do so tomorrow at work :) |
| 04:39 | <railgun> | thanks! |
| 06:41 | <annevk> | railgun: the <dl> needs to be inside the <ol> unfortunately as a step; returning good needs to be the last step applicable to all types |
| 06:42 | <annevk> | railgun: my instructions were faulty :/ |
| 15:54 | <railgun> | annevk: is there an example somewhere in the source that I can reference? I'm still not sure where to put the ol and li tags |
| 17:50 | <annevk> | railgun: I hope Domenic can help out; I’m back in a week |
| 17:51 | <Domenic> | railgun: basically the algorithm should not just be a <dl> |
| 17:51 | <Domenic> | It should be an <ol> with two items |
| 17:51 | <Domenic> | 1. Switch on image |
| 17:51 | <Domenic> | 2. Return good |
| 17:51 | <Domenic> | And in more detail on 1 |
| 17:51 | <Domenic> | <li><p>Switch on image:</p> <dl>...</dl></li> |
| 17:51 | <Domenic> | (well, I forgot the <var> I guess) |
| 18:38 | <railgun> | Domenic: is this correct? https://i.imgur.com/gaBvJcf.jpg |
| 18:40 | <railgun> | output is https://i.imgur.com/NJkkWnD.jpg |
| 19:07 | <Domenic> | railgun: looks perfect! |
| 19:55 | <railgun> | Domenic: one last thing, should I add "run these steps" back to the first sentence? |
| 19:56 | <Domenic> | railgun: hmm good question. We're pretty inconsistent so far. I guess maybe add it back to minimize changes. Maybe one day we'll figure out whether we want to be consistent there. |
| 20:10 | <railgun> | Domenic: done and updated |
| 20:22 | <railgun> | https://i.imgur.com/PaPDRw3.png hope this is fine (I can amend my commit if it's really needed) |
| 21:07 | <Domenic> | Ah, I missed that. Would have been better to not do that, but no big deal. (And not worth fixing now.) |
| 21:09 | <Domenic> | Congrats on your first contribution! As I said on the PR, it's a really nice one :) |
| 21:15 | <railgun> | thanks for the help |
| 22:14 | <railgun> | learned a lot from doing that issue, hope you don't mind if I take on some more issues later |
| 23:38 | <Domenic> | For sure, I'm looking forward to it! |
