00:21
<falken>
What's the best way to edit a commit description for a pull request that hasn't yet been merged? I recall seeing that just editing the pull request description doesn't help the person doing the merge, and it's preferred that the first commit have a good description.
00:25
<MikeSmith>
falken: `git commit --amend .` on the PR branch?
00:28
<MikeSmith>
TimothyGu: yeah stretch
00:30
<falken>
MikeSmith: Thanks
00:33
<MikeSmith>
TimothyGu: stretch-backports has nginx 1.13, which apparently includes TLS 1.3 support https://ma.ttias.be/enable-tls-1-3-nginx/
02:50
<Domenic>
Yeah I'm not sure the XXX for unfinished work filter is all that useful; we may want to just remove it
04:56
<annevk>
falken: for WHATWG PRs you can also leave a comment with a proposed commit message
04:57
<annevk>
falken: we typically use squash & merge anyway
05:26
<falken>
annevk: thanks
09:09
<smaug____>
hmm, I guess I should start to look at tpac schedule and such
09:11
<annevk>
smaug____: I hope you registered for the discounted rates?
09:22
<smaug____>
I didn't
11:53
<zcorpan>
Fun with different rendering http://software.hixie.ch/utilities/js/live-dom-viewer/saved/6088
14:07
<annevk>
zcorpan: https://docs.google.com/document/d/1JM0YmKNRmhl1nEqcg_M_KlxBg_q7LIz9xgzmbrHp34o/edit seems quite nice if we can make that work
14:07
<annevk>
zcorpan: it roughly matches what I proposed long ago, except mine had display values
14:08
<annevk>
zcorpan: perhaps with an actual draft specification that includes a bunch more details implementations will this time around be compelled to go for it
14:08
<zcorpan>
annevk: yeah. web compat requires most display values to be ignored
14:08
<zcorpan>
i hope so
14:09
<annevk>
zcorpan: one thing we could do for now is to just say these are !important styles in the UA style sheet
14:09
<annevk>
zcorpan: if impls are not willing to make it swappable
14:09
<annevk>
(plus I guess some other magic so you can't use it elsewhere)
14:10
<zcorpan>
annevk: an important property is to be able to turn it off ^_^ i'd specify it differently if it's supposed to match how it's implemented now
14:14
<zcorpan>
I'm trying to identify browser developers who can fix fieldset bugs, not much luck so far
14:18
<annevk>
zcorpan: I wouldn't hold out hope of that all coming together within 30 days
14:18
<zcorpan>
At least I can try :)
14:19
<annevk>
zcorpan: success to me would be something that describes and improves upon the status quo + tests, and various bugs against browsers for the improvements, and being able to close the existing whatwg/html issues
14:20
<annevk>
zcorpan: but yeah, if we could get that too 😊
14:35
<smaug____>
annevk: do you recall anything mouseenter/leave specific event dispatch handling when target is in shadow DOM
14:39
<annevk>
smaug____: no
14:46
<smaug____>
ahaa, this indeed very much smells like a blink bug
14:46
<smaug____>
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/input/boundary_event_dispatcher.cc?gsn=SendBoundaryEvents&l=76-79
14:46
<smaug____>
hayato: ^
16:28
<dimitarfn>
Hello, I have a question
16:28
<dimitarfn>
Why does the project that aims at building HTML
16:29
<dimitarfn>
... have the worst looking website ever?
16:29
<dimitarfn>
has*
17:23
<annevk>
Not much of a question if you can't wait around for the answer...
17:28
<smaug____>
is there some code indexing tool for webkit?
17:31
<annevk>
smaug____: nothing quite like searchfox
17:32
<annevk>
smaug____: there's https://trac.webkit.org/ but I guess you know about that
17:32
<smaug____>
yeah, that I know about. It isn't really indexing tool
17:33
<annevk>
Yeah, it's slow too
17:33
<annevk>
smaug____: perhaps you can convince Bill to add WebKit to searchfox?
17:34
<smaug____>
would feel a bit odd if Mozilla provided the only useful code indexing tool for webkit :p
17:35
<annevk>
smaug____: it'd be useful though
17:36
<TimothyGu>
I think there was some interest to get it added to cs.chromium.org too (but not enough interest to make it a thing)
17:37
<annevk>
Basically I often want to quickly check how things are implemented to verify assumptions and in practice I end up ignoring WebKit due to it being so bad at this
17:50
<Domenic>
The GitHub mirror is at least better than trac
17:50
<smaug____>
somehow usability of cs.chromium.org is quite far from searchfox
18:58
<annevk>
Domenic: GitHub search does not search commit messages though, right?
18:59
<Domenic>
Yeah I guess not. Does trac?
18:59
<annevk>
I think so, but with trac code search is bad
20:13
<TabAtkins>
If I did, beleive me, the UI would be there immediately.
20:13
<TabAtkins>
Sorry, accidental history re-post.
22:19
<TimothyGu>
annevk: github search does search commit message
22:20
<TimothyGu>
https://github.com/whatwg/html/search?q=empty&type=Commits