| 09:47 | <annevk> | yoav: I'm not sure how I'm supposed to review https://github.com/web-platform-tests/wpt/pull/13518 |
| 09:48 | <annevk> | yoav: the "current model" is not sound and I'm also not an expert in it |
| 09:50 | <yoav> | OK |
| 09:52 | <yoav> | annevk: I think there's value in adding those tests, to make sure current implementations are abiding to this model, even if we'd prefer to move to a more restrictive one in the future |
| 09:52 | <yoav> | but if you feel uncomfortable reviewing, I can try to find someone else |
| 09:54 | <annevk> | yoav: I do, thanks |
| 12:35 | <ondras> | w 24 |
| 12:35 | <ondras> | damn sorry |
| 13:58 | <Bitgod> | Good morning friends :) |
| 14:00 | <annevk> | Ms2ger: where does https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty invoke a getter? |
| 14:02 | <Ms2ger> | annevk, I don't think it does, why do you ask? |
| 14:04 | <annevk> | Ms2ger: I'm trying to figure out https://github.com/heycam/webidl/pull/713 |
| 14:06 | <Ms2ger> | annevk, I was suggesting [[Set]] and [[DefineOwnProperty]] didn't really need to be consistent, because they're doing different things |
| 14:07 | <annevk> | Ms2ger: I think I see now |
| 14:08 | <annevk> | Ms2ger: I guess I don't quite see why we have the "supports" abstraction |
| 14:08 | <annevk> | Ms2ger: why not see "if it has a getter" and "if it has a setter" throughout |
| 14:08 | <Ms2ger> | annevk, that would be fine by me |
| 14:09 | <annevk> | Ms2ger: it seems that heycam's strategy was that there's "supports" which you always use and then there's specializations |
| 14:09 | <annevk> | Ms2ger: I'm fine with going the other way, but it'd be good to be consistent about it or at least file an issue about such a plan? |
| 14:09 | <Ms2ger> | annevk, I'll file the issue |
| 14:09 | <annevk> | ta |
| 16:09 | <dtapuska> | annevk: I'd like to get https://github.com/whatwg/fetch/pull/853 merged but not sure how to proceed cause I don't know what we should do there. Firefox has landed code already matching the PR and the tests |
| 16:10 | <annevk> | dtapuska: I don’t understand how the note is true necessarily |
| 16:11 | <annevk> | dtapuska: I also don’t have time right now unfortunately |
| 16:11 | <annevk> | dtapuska: maybe JakeA can help me tomorrow? |
| 16:13 | <dtapuska> | annevk: let me explain why I wrote the note.. previously when stale while revalidate was implemented it was implemented at the network service so there wasn't any attribution of the revalidation request with the page doing the fetching. So if it started a revalidation of say a gigantic resource it wouldn't get terminated because the network service was doing the fetching it wasn't associated with the browsing context being |
| 16:13 | <dtapuska> | terminated. |
| 18:24 | <Domenic> | annevk: did you want to give https://github.com/whatwg/html/pull/4465 another look? |
| 20:32 | <annevk> | dtapuska: the problem is that not all fetches have a context iirc |
| 20:32 | <annevk> | Domenic: I was hoping for someone else, maybe JakeA? |
| 22:31 | <Domenic> | JakeA would be ideal, I hope he can make time :) |